[v24.x backport] watch: get flags from execArgv#62108
Closed
efekrskl wants to merge 1 commit intonodejs:v24.x-stagingfrom
Closed
[v24.x backport] watch: get flags from execArgv#62108efekrskl wants to merge 1 commit intonodejs:v24.x-stagingfrom
efekrskl wants to merge 1 commit intonodejs:v24.x-stagingfrom
Conversation
PR-URL: nodejs#61779 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Codecov Reportβ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v24.x-staging #62108 +/- ##
================================================
Coverage 90.10% 90.11%
================================================
Files 667 670 +3
Lines 199019 200385 +1366
Branches 38911 39086 +175
================================================
+ Hits 179335 180572 +1237
- Misses 12040 12125 +85
- Partials 7644 7688 +44 π New features to boost your workflow:
|
Contributor
|
The original commit lands cleanly on v24.x-staging, it's easier to skip the backport PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #61779
The original issue was on 24.x and there seems to be need of a backport