Skip to content

[v24.x backport] watch: get flags from execArgv#62108

Closed
efekrskl wants to merge 1 commit intonodejs:v24.x-stagingfrom
efekrskl:backport-61779-to-24
Closed

[v24.x backport] watch: get flags from execArgv#62108
efekrskl wants to merge 1 commit intonodejs:v24.x-stagingfrom
efekrskl:backport-61779-to-24

Conversation

@efekrskl
Copy link
Contributor

@efekrskl efekrskl commented Mar 4, 2026

Backports #61779

The original issue was on 24.x and there seems to be need of a backport

PR-URL: #61779
Reviewed-By: Moshe Atlow moshe@atlow.co.il
Reviewed-By: Yagiz Nizipli yagiz@nizipli.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com
Reviewed-By: Marco Ippolito marcoippolito54@gmail.com

PR-URL: nodejs#61779
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch. labels Mar 4, 2026
@codecov
Copy link

codecov bot commented Mar 5, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 90.11%. Comparing base (065c9b0) to head (36ddaad).
⚠️ Report is 140 commits behind head on v24.x-staging.

Additional details and impacted files
@@               Coverage Diff                @@
##           v24.x-staging   #62108     +/-   ##
================================================
  Coverage          90.10%   90.11%             
================================================
  Files                667      670      +3     
  Lines             199019   200385   +1366     
  Branches           38911    39086    +175     
================================================
+ Hits              179335   180572   +1237     
- Misses             12040    12125     +85     
- Partials            7644     7688     +44     

see 170 files with indirect coverage changes

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95
Copy link
Contributor

aduh95 commented Mar 9, 2026

The original commit lands cleanly on v24.x-staging, it's easier to skip the backport PR

@aduh95 aduh95 closed this Mar 9, 2026
@efekrskl efekrskl deleted the backport-61779-to-24 branch March 9, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. v24.x Issues that can be reproduced on v24.x or PRs targeting the v24.x-staging branch.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants